seth
/
jam-cloud
mirror of https://bitbucket.org/jamkazam/jam-cloud.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

fix(24-01): correct recording method names in useRecordingHelpers 

- Change StartMediaRecording to StartRecording with unpacked params
- Change FrontStopRecording to StopRecording
- Match legacy recordingModel.js signature for C++ client
This commit is contained in:
Nuwan 2026-02-19 15:21:02 +05:30
parent 94ae383267
commit 45aeb04eb2
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
jam-ui/src/hooks/useRecordingHelpers.js
View File

@ -97,8 +97,12 @@ const useRecordingHelpers = (jamClient) => {
setCurrentOrLastRecordingId(recording.id);
const groupedTracks = groupTracksToClient(recording);
console.log("jamClient#StartMediaRecording", recordSettings);
await jamClient.StartMediaRecording(recording.id, groupedTracks, recordSettings);
// Unpack settings for C++ client (matches legacy recordingModel.js signature)
const recordVideoType = recordSettings.videoType || 0;
const recordChat = recordSettings.recordChat ? 1 : 0;
const recordFramerate = 0;
console.log("jamClient#StartRecording", recording.id, groupedTracks, recordVideoType, recordChat, recordFramerate);
await jamClient.StartRecording(recording.id, groupedTracks, recordVideoType, recordChat, recordFramerate);
} catch (jqXHR) {
console.warn("failed to startRecording due to server issue:", jqXHR.responseJSON);
const details = { clientId: app.clientId, reason: 'rest', detail: jqXHR.responseJSON, isRecording: false };
@ -163,7 +167,7 @@ const useRecordingHelpers = (jamClient) => {
const recording = await currentRecording;
const groupedTracks = groupTracksToClient(recording);
await jamClient.FrontStopRecording(recording.id, groupedTracks);
await jamClient.StopRecording(recording.id, groupedTracks);
if (thisClientStartedRecording) {
try {