From 45aeb04eb27526f49f8665c256362f26c3678f04 Mon Sep 17 00:00:00 2001 From: Nuwan Date: Thu, 19 Feb 2026 15:21:02 +0530 Subject: [PATCH] fix(24-01): correct recording method names in useRecordingHelpers - Change StartMediaRecording to StartRecording with unpacked params - Change FrontStopRecording to StopRecording - Match legacy recordingModel.js signature for C++ client --- jam-ui/src/hooks/useRecordingHelpers.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/jam-ui/src/hooks/useRecordingHelpers.js b/jam-ui/src/hooks/useRecordingHelpers.js index 7e93b43af..420f8fe86 100644 --- a/jam-ui/src/hooks/useRecordingHelpers.js +++ b/jam-ui/src/hooks/useRecordingHelpers.js @@ -97,8 +97,12 @@ const useRecordingHelpers = (jamClient) => { setCurrentOrLastRecordingId(recording.id); const groupedTracks = groupTracksToClient(recording); - console.log("jamClient#StartMediaRecording", recordSettings); - await jamClient.StartMediaRecording(recording.id, groupedTracks, recordSettings); + // Unpack settings for C++ client (matches legacy recordingModel.js signature) + const recordVideoType = recordSettings.videoType || 0; + const recordChat = recordSettings.recordChat ? 1 : 0; + const recordFramerate = 0; + console.log("jamClient#StartRecording", recording.id, groupedTracks, recordVideoType, recordChat, recordFramerate); + await jamClient.StartRecording(recording.id, groupedTracks, recordVideoType, recordChat, recordFramerate); } catch (jqXHR) { console.warn("failed to startRecording due to server issue:", jqXHR.responseJSON); const details = { clientId: app.clientId, reason: 'rest', detail: jqXHR.responseJSON, isRecording: false }; @@ -163,7 +167,7 @@ const useRecordingHelpers = (jamClient) => { const recording = await currentRecording; const groupedTracks = groupTracksToClient(recording); - await jamClient.FrontStopRecording(recording.id, groupedTracks); + await jamClient.StopRecording(recording.id, groupedTracks); if (thisClientStartedRecording) { try {