From fb1d18ce6bace1295ff3604ff95e3f555bf45502 Mon Sep 17 00:00:00 2001 From: Nuwan Chathuranga Date: Thu, 17 Jun 2021 00:47:53 +0530 Subject: [PATCH] fix error showing latency badge this fixes the issue of not showing the correct latency badge on when hover over more than one user --- web/app/assets/javascripts/hoverMusician.js | 6 +++--- .../react-components/stores/LatencyStore.js.coffee | 7 ++++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/web/app/assets/javascripts/hoverMusician.js b/web/app/assets/javascripts/hoverMusician.js index 3285e8c62..e7a597163 100644 --- a/web/app/assets/javascripts/hoverMusician.js +++ b/web/app/assets/javascripts/hoverMusician.js @@ -203,9 +203,9 @@ } function bindUserLatencyFail(){ - $(document).one('user_latency_fail', function(e, failedUserIds){ - //logger.debug("bindUserLatencyFail", failedUserIds) - if(_.contains(failedUserIds, userId)){ + $(document).one('user_latency_fail', function(e, failedResp){ + //logger.debug("bindUserLatencyFail", failedResp) + if(_.contains(failedResp.user_ids, userId)){ showFailedLatencyBadge(userId) } }); diff --git a/web/app/assets/javascripts/react-components/stores/LatencyStore.js.coffee b/web/app/assets/javascripts/react-components/stores/LatencyStore.js.coffee index 792c90752..556bc25c3 100644 --- a/web/app/assets/javascripts/react-components/stores/LatencyStore.js.coffee +++ b/web/app/assets/javascripts/react-components/stores/LatencyStore.js.coffee @@ -19,7 +19,7 @@ rest = new context.JK.Rest() @trigger(users: { @latencies }) onResolve: (user_ids) -> - rest.getLatencyToUsers({user_ids: user_ids}).done((response) => @onLoaded(response)).fail((jqXHR) => @onLatencyFail(jqXHR, [user_ids])) + rest.getLatencyToUsers({user_ids: user_ids}).done((response) => @onLoaded(response)).fail((jqXHR) => @onLatencyFail(jqXHR, user_ids)) onLoaded: (response) -> usersLatencies = response.users @@ -31,8 +31,9 @@ rest = new context.JK.Rest() LatencyActions.fail(user_ids) onFail:(user_ids) -> - $(document).triggerHandler("user_latency_fail", user_ids) - @trigger(user_ids) + logger.debug("onLatencyFail", { user_ids: user_ids }) + $(document).triggerHandler("user_latency_fail", { user_ids: user_ids }) + @trigger( { user_ids: user_ids } ) getState:() -> { latencies: @latencies }