seth
/
jam-cloud
mirror of https://bitbucket.org/jamkazam/jam-cloud.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

fix(24-01): revert to original StartMediaRecording method 

The original research was incorrect - jam-ui uses StartMediaRecording
(enum 428) not StartRecording (enum 377). These are different methods
in the C++ client.

Reverted to original method signatures:
- StartMediaRecording(id, groupedTracks, recordSettings)
- FrontStopRecording(id, groupedTracks)

The JSON parsing fix in rest.js (previous commit) is the actual fix
that resolves recording.id being undefined.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Nuwan 2026-02-19 21:10:13 +05:30
parent 0766e6b99f
commit e1065430e5
2 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
jam-ui/src/components/client/JKSessionScreen.js
View File

@ -876,12 +876,8 @@ const JKSessionScreen = () => {
const currentRecordingId = recording.id;
// console.debug("Recording started with ID: ", currentRecordingId);
const groupedTracks = groupTracksToClient(recording);
// Unpack params for C++ client (matches legacy recordingModel.js signature)
const recordVideo = params.videoType || 0;
const recordChat = params.recordChat ? 1 : 0;
const recordFramerate = 0;
try {
await jamClient.StartRecording(currentRecordingId, groupedTracks, recordVideo, recordChat, recordFramerate);
await jamClient.StartMediaRecording(currentRecordingId, groupedTracks, params);
} catch (error) {
// console.error("Error starting media recording:", error);
}

10
jam-ui/src/hooks/useRecordingHelpers.js
View File

@ -97,12 +97,8 @@ const useRecordingHelpers = (jamClient) => {
setCurrentOrLastRecordingId(recording.id);
const groupedTracks = groupTracksToClient(recording);
// Unpack settings for C++ client (matches legacy recordingModel.js signature)
const recordVideoType = recordSettings.videoType || 0;
const recordChat = recordSettings.recordChat ? 1 : 0;
const recordFramerate = 0;
console.log("jamClient#StartRecording", recording.id, groupedTracks, recordVideoType, recordChat, recordFramerate);
await jamClient.StartRecording(recording.id, groupedTracks, recordVideoType, recordChat, recordFramerate);
console.log("jamClient#StartMediaRecording", recording.id, groupedTracks, recordSettings);
await jamClient.StartMediaRecording(recording.id, groupedTracks, recordSettings);
} catch (jqXHR) {
console.warn("failed to startRecording due to server issue:", jqXHR.responseJSON);
const details = { clientId: app.clientId, reason: 'rest', detail: jqXHR.responseJSON, isRecording: false };
@ -167,7 +163,7 @@ const useRecordingHelpers = (jamClient) => {
const recording = await currentRecording;
const groupedTracks = groupTracksToClient(recording);
await jamClient.StopRecording(recording.id, groupedTracks);
await jamClient.FrontStopRecording(recording.id, groupedTracks);
if (thisClientStartedRecording) {
try {