VRFS-3036 tightening code

web/app/assets/javascripts/member_search_filter.js.coffee

@@ -94,16 +94,14 @@ context.JK.BaseSearchFilter = class BaseSearchFilter
     @screen.find('#search-filter-genres').empty()
     @rest.getGenres().done (genres) =>
       genreTemplate = @screen.find('#template-search-filter-setup-genres').html()
+      filterGenres = this.filterData().genres
       $.each genres, (index, genre) =>
-        if 0 < this.filterData().genres.length 
-          genreMatch = $.grep(this.filterData().genres, (n, i) ->
+        if 0 < filterGenres.length 
+          genreMatch = $.grep(filterGenres, (n, i) ->
             n == genre.id) 
         else 
           genreMatch = []    
-        if genreMatch.length > 0    
-          selected = 'checked' 
-        else
-          selected = '' 
+        if genreMatch.length > 0 then selected = 'checked' else selected = ''
         genreHtml = context.JK.fillTemplate(genreTemplate,
           id: genre.id
           description: genre.description