diff --git a/web/app/assets/javascripts/fakeJamClientRecordings.js b/web/app/assets/javascripts/fakeJamClientRecordings.js index 5fd412e0b..9fee4360f 100644 --- a/web/app/assets/javascripts/fakeJamClientRecordings.js +++ b/web/app/assets/javascripts/fakeJamClientRecordings.js @@ -34,8 +34,8 @@ function StartRecording(recordingId, clients) { startingSessionState = {}; - // we expect all clients to respond within 3 seconds to mimic the reliable UDP layer - startingSessionState.aggegratingStartResultsTimer = setTimeout(timeoutStartRecordingTimer, 3000); + // we expect all clients to respond within 1 seconds to mimic the reliable UDP layer + startingSessionState.aggegratingStartResultsTimer = setTimeout(timeoutStartRecordingTimer, 1000); startingSessionState.recordingId = recordingId; startingSessionState.groupedClientTracks = copyClientIds(clients, app.clientId); // we will manipulate this new one @@ -70,8 +70,8 @@ stoppingSessionState = {}; - // we expect all clients to respond within 3 seconds to mimic the reliable UDP layer - stoppingSessionState.aggegratingStopResultsTimer = setTimeout(timeoutStopRecordingTimer, 3000); + // we expect all clients to respond within 1 seconds to mimic the reliable UDP layer + stoppingSessionState.aggegratingStopResultsTimer = setTimeout(timeoutStopRecordingTimer, 1000); stoppingSessionState.recordingId = recordingId; stoppingSessionState.groupedClientTracks = copyClientIds(clients, app.clientId); diff --git a/web/app/assets/javascripts/session.js b/web/app/assets/javascripts/session.js index 8f9da6756..2fc9e00b1 100644 --- a/web/app/assets/javascripts/session.js +++ b/web/app/assets/javascripts/session.js @@ -385,6 +385,7 @@ }) .on('stoppedRecording', function(e, data) { if(data.reason) { + logger.warn("Recording Discarded: ", data); var reason = data.reason; var detail = data.detail; diff --git a/web/spec/features/recordings_spec.rb b/web/spec/features/recordings_spec.rb index c81a0f493..11518092a 100644 --- a/web/spec/features/recordings_spec.rb +++ b/web/spec/features/recordings_spec.rb @@ -47,11 +47,10 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature # confirms that if someone leaves 'ugly' (without calling 'Leave' REST API), that the recording is junked it "creator starts and then abruptly leave" do - pending "shows 'recording finished'" start_recording_with(creator, [joiner1]) in_client(creator) do - close_websocket + visit "/request_reset_password" # kills websocket, looking like an abrupt leave end in_client(joiner1) do @@ -81,11 +80,10 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature # confirms that if someone leaves 'ugly' (without calling 'Leave' REST API), that the recording is junked with 3 participants it "creator starts and then abruptly leave with 3 participants" do - pending "shows 'recording finished'" start_recording_with(creator, [joiner1, joiner2]) in_client(creator) do - close_websocket + visit "/request_reset_password" # kills websocket, looking like an abrupt leave end in_client(joiner1) do