From 9a41e8a236c0c9043a1dcf57e5020d1e398a8dcc Mon Sep 17 00:00:00 2001 From: Seth Call Date: Fri, 25 Jul 2025 20:06:47 -0500 Subject: [PATCH] Fix cutoff_date not being passed in and requirees of TestGearSetup --- ruby/lib/jam_ruby.rb | 1 + ruby/lib/jam_ruby/lib/gear_setup_reminder.rb | 10 +++++----- ruby/lib/jam_ruby/lib/test_gear_reminder.rb | 10 +++++----- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/ruby/lib/jam_ruby.rb b/ruby/lib/jam_ruby.rb index ea2654040..40604d0ec 100755 --- a/ruby/lib/jam_ruby.rb +++ b/ruby/lib/jam_ruby.rb @@ -123,6 +123,7 @@ require "jam_ruby/lib/musician_filter" require "jam_ruby/lib/email_profile_reminder" require "jam_ruby/lib/email_signup_survey" require "jam_ruby/lib/gear_setup_reminder" +require "jam_ruby/lib/test_gear_reminder" require "jam_ruby/amqp/amqp_connection_manager" require "jam_ruby/database" require "jam_ruby/message_factory" diff --git a/ruby/lib/jam_ruby/lib/gear_setup_reminder.rb b/ruby/lib/jam_ruby/lib/gear_setup_reminder.rb index c8e91ce89..bad88850d 100644 --- a/ruby/lib/jam_ruby/lib/gear_setup_reminder.rb +++ b/ruby/lib/jam_ruby/lib/gear_setup_reminder.rb @@ -7,23 +7,23 @@ module JamRuby begin cutoff_date = Date.parse(Rails.application.config.gear_setup_reminders_effective_from_date) # Define a cutoff date for the survey/gear setup emails - reminder1_users(cutoff_date).find_each do |user| + reminder1_users(cutoff_date).find_each(batch_size:100) do |user| UserMailer.gear_setup_reminder1(user).deliver_now User.where(id: user.id).update_all(gear_setup_reminder1_sent_at: Time.now) end - reminder2_users(cutoff_date).find_each do |user| + reminder2_users(cutoff_date).find_each(batch_size:100) do |user| UserMailer.gear_setup_reminder2(user).deliver_now User.where(id: user.id).update_all(gear_setup_reminder2_sent_at: Time.now) end - reminder3_users(cutoff_date).find_each do |user| + reminder3_users(cutoff_date).find_each(batch_size:100) do |user| UserMailer.gear_setup_reminder3(user).deliver_now User.where(id: user.id).update_all(gear_setup_reminder3_sent_at: Time.now) end rescue Exception => e - @@log.error("unable to send gear setup reminder email #{e}") - puts "unable to send gear setup reminder email #{e}" + @@log.error("unable to send GearSetupReminder email #{e}") + puts "unable to send GearSetupReminder email #{e}" end end diff --git a/ruby/lib/jam_ruby/lib/test_gear_reminder.rb b/ruby/lib/jam_ruby/lib/test_gear_reminder.rb index aa3afa55a..b9f1eb365 100644 --- a/ruby/lib/jam_ruby/lib/test_gear_reminder.rb +++ b/ruby/lib/jam_ruby/lib/test_gear_reminder.rb @@ -6,23 +6,23 @@ module JamRuby def self.send_reminders begin cutoff_date = Date.parse(Rails.application.config.test_gear_reminders_effective_from_date) # Define a cutoff date for the test gear setup emails - reminder1_users.find_each(batch_size:100) do |user| + reminder1_users(cutoff_date).find_each(batch_size:100) do |user| UserMailer.test_gear_reminder1(user).deliver_now User.where(id: user.id).update_all(test_gear_reminder1_sent_at: Time.now) end - reminder2_users.find_each(batch_size:100) do |user| + reminder2_users(cutoff_date).find_each(batch_size:100) do |user| UserMailer.test_gear_reminder2(user).deliver_now User.where(id: user.id).update_all(test_gear_reminder2_sent_at: Time.now) end - reminder3_users.find_each(batch_size:100) do |user| + reminder3_users(cutoff_date).find_each(batch_size:100) do |user| UserMailer.test_gear_reminder3(user).deliver_now User.where(id: user.id).update_all(test_gear_reminder3_sent_at: Time.now) end rescue Exception => e - @@log.error("unable to send gear setup reminder email #{e}") - puts "unable to send gear setup reminder email #{e}" + @@log.error("unable to send TestGearReminder email #{e}") + puts "unable to send TestGearReminder email #{e}" end end