From 91ca1af98bcfb3a13ee83c1498fcdc12a5bbb7bd Mon Sep 17 00:00:00 2001 From: Jonathan Kolyer Date: Sun, 11 May 2014 06:42:20 +0000 Subject: [PATCH] VRFS-736 like us GA support --- .../app/views/layouts/user_mailer.html.erb | 4 ++-- web/app/assets/javascripts/ga.js | 9 ++++++--- web/app/assets/javascripts/utils.js | 5 ++++- web/app/controllers/users_controller.rb | 14 +++++++++++++- web/app/views/clients/_footer.html.erb | 7 ------- web/app/views/users/welcome.html.haml | 12 ++++++++++++ 6 files changed, 37 insertions(+), 14 deletions(-) diff --git a/ruby/lib/jam_ruby/app/views/layouts/user_mailer.html.erb b/ruby/lib/jam_ruby/app/views/layouts/user_mailer.html.erb index 159221f5b..d12abf802 100644 --- a/ruby/lib/jam_ruby/app/views/layouts/user_mailer.html.erb +++ b/ruby/lib/jam_ruby/app/views/layouts/user_mailer.html.erb @@ -49,8 +49,8 @@ diff --git a/web/app/assets/javascripts/ga.js b/web/app/assets/javascripts/ga.js index a2d30f72b..9b5ea6d24 100644 --- a/web/app/assets/javascripts/ga.js +++ b/web/app/assets/javascripts/ga.js @@ -79,7 +79,10 @@ band : 'Band', fan : 'Fan', recording : 'Recording', - session : 'Session' + session : 'Session', + facebook: 'facebook', + twitter: 'twitter', + google: 'google', }; var categories = { @@ -271,11 +274,11 @@ context.ga('send', 'event', categories.band, bandAction); } - function trackJKSocial(category, target) { + function trackJKSocial(category, target, data) { assertOneOf(category, categories); assertOneOf(target, jkSocialTargets); - context.ga('send', 'event', category, target); + context.ga('send', 'event', category, target, data); } diff --git a/web/app/assets/javascripts/utils.js b/web/app/assets/javascripts/utils.js index fd689608d..9ba52282f 100644 --- a/web/app/assets/javascripts/utils.js +++ b/web/app/assets/javascripts/utils.js @@ -608,7 +608,10 @@ }; context.JK.clientType = function () { - return context.jamClient.IsNativeClient() ? 'client' : 'browser'; + if (context.jamClient) { + return context.jamClient.IsNativeClient() ? 'client' : 'browser'; + } + return 'browser'; } /** * Returns 'MacOSX' if the os appears to be macintosh, diff --git a/web/app/controllers/users_controller.rb b/web/app/controllers/users_controller.rb index 3a52f9e3b..b27fbfae6 100644 --- a/web/app/controllers/users_controller.rb +++ b/web/app/controllers/users_controller.rb @@ -386,7 +386,19 @@ class UsersController < ApplicationController elsif 'google'==service url = "https://plus.google.com/share?url=#{url}" end - redirect_to url + if 'email'==params[:src] + js =< +$(function() { + JK.GA.trackJKSocial(JK.GA.Categories.jkLike, '#{service}', 'browser'); + window.location = "#{url}"; +}); + +JS + render :inline => js, :layout => 'landing' + else + redirect_to url + end end private diff --git a/web/app/views/clients/_footer.html.erb b/web/app/views/clients/_footer.html.erb index 5ac12e675..5c4fee259 100644 --- a/web/app/views/clients/_footer.html.erb +++ b/web/app/views/clients/_footer.html.erb @@ -1,10 +1,3 @@ -
-
- <% [:twitter, :facebook, :google].each do |src| %> - <%= link_to(image_tag("content/icon_#{src}.png", :style => "vertical-align:top"), "/endorse/0/#{src}") %>  - <% end %> -
-
- <% [:twitter, :facebook, :google].each do |src| %> - <%= link_to(image_tag("http://www.jamkazam.com/assets/content/icon_#{src}.png", :style => "vertical-align:top"), "http://www.jamkazam.com/endorse/@USERID/#{src}") %>  + <% [:twitter, :facebook, :google].each do |site| %> + <%= link_to(image_tag("http://www.jamkazam.com/assets/content/icon_#{site}.png", :style => "vertical-align:top"), "http://www.jamkazam.com/endorse/@USERID/#{site}?src=email") %>  <% end %>