From 6bd6958df151a5dc2ef93108d76f6a24ee78d086 Mon Sep 17 00:00:00 2001 From: Seth Call Date: Mon, 1 Feb 2021 18:59:47 -0600 Subject: [PATCH] Always close rating dialog on submit --- ruby/spec/mailers/render_emails_spec.rb | 3 --- web/app/assets/javascripts/dialog/rateSessionDialog.js | 3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/ruby/spec/mailers/render_emails_spec.rb b/ruby/spec/mailers/render_emails_spec.rb index 4c2d44210..c663ed666 100644 --- a/ruby/spec/mailers/render_emails_spec.rb +++ b/ruby/spec/mailers/render_emails_spec.rb @@ -363,8 +363,6 @@ describe "RenderMailers", :slow => true do save_emails_to_disk(mail, @filename) end - - it "invite_school_teacher" do @filename = "invite_school_teacher" UserMailer.invite_school_teacher(FactoryGirl.create(:school_invitation, as_teacher: true)).deliver_now @@ -499,7 +497,6 @@ describe "RenderMailers", :slow => true do @filename="daily_sessions"; scheduled_batch.deliver_batch end end - end def save_emails_to_disk(mail, filename) diff --git a/web/app/assets/javascripts/dialog/rateSessionDialog.js b/web/app/assets/javascripts/dialog/rateSessionDialog.js index 8142dd75f..a81a26821 100644 --- a/web/app/assets/javascripts/dialog/rateSessionDialog.js +++ b/web/app/assets/javascripts/dialog/rateSessionDialog.js @@ -97,6 +97,7 @@ var backendDetails = context.jamClient.getAllClientsStateMap() console.log("got backend details", backendDetails) } + $.ajax({ type: "POST", url: url, @@ -108,8 +109,8 @@ } else if (0 > qq){ context.JK.GA.trackSessionQuality(context.JK.GA.SessionQualityTypes.poor); } - closeDialog(); }); + closeDialog(); return false; }); }