a small cleanup of connection fields and fix broken tests

db/manifest

@@ -149,3 +149,4 @@ chat_messages.sql
 diagnostics.sql
 user_mods.sql
 connection_stale_expire.sql
+fix_connection_fields.sql

db/up/fix_connection_fields.sql

@@ -0,0 +1,8 @@
+ALTER TABLE connections ALTER COLUMN user_id SET NOT NULL;
+ALTER TABLE connections ALTER COLUMN ip_address SET NOT NULL;
+
+ALTER TABLE connections DROP COLUMN latitude;
+ALTER TABLE connections DROP COLUMN longitude;
+ALTER TABLE connections DROP COLUMN countrycode;
+ALTER TABLE connections DROP COLUMN region;
+ALTER TABLE connections DROP COLUMN city;

ruby/lib/jam_ruby/connection_manager.rb

@@ -75,28 +75,13 @@ module JamRuby
         if location.nil?
           # todo what's a better default location?
           locidispid = 0
-          latitude = 0.0
-          longitude = 0.0
-          countrycode = 'US'
-          region = 'TX'
-          city = 'Austin'
         else
           locidispid = locid*1000000+ispid
-          latitude = location.latitude
-          longitude = location.longitude
-          countrycode = location.countrycode
-          region = location.region
-          city = location.city
         end
 
         conn.ip_address = ip_address
         conn.addr = addr
         conn.locidispid = locidispid
-        conn.latitude = latitude
-        conn.longitude = longitude
-        conn.countrycode = countrycode
-        conn.region = region
-        conn.city = city
         conn.save!(validate: false)
       end
 
@@ -230,24 +215,14 @@ SQL
         if location.nil?
           # todo what's a better default location?
           locidispid = 0
-          latitude = 0.0
-          longitude = 0.0
-          countrycode = 'US'
-          region = 'TX'
-          city = 'Austin'
         else
           locidispid = locid*1000000+ispid
-          latitude = location.latitude
-          longitude = location.longitude
-          countrycode = location.countrycode
-          region = location.region
-          city = location.city
         end
 
         lock_connections(conn)
 
-        conn.exec("INSERT INTO connections (user_id, client_id, ip_address, client_type, addr, locidispid, latitude, longitude, countrycode, region, city, aasm_state) VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12)",
-                                           [user_id, client_id, ip_address, client_type, addr, locidispid, latitude, longitude, countrycode, region, city, Connection::CONNECT_STATE.to_s]).clear
+        conn.exec("INSERT INTO connections (user_id, client_id, ip_address, client_type, addr, locidispid, aasm_state) VALUES ($1, $2, $3, $4, $5, $6, $7)",
+                                           [user_id, client_id, ip_address, client_type, addr, locidispid, Connection::CONNECT_STATE.to_s]).clear
 
         # we just created a new connection-if this is the first time the user has shown up, we need to send out a message to his friends
         conn.exec("SELECT count(user_id) FROM connections WHERE user_id = $1", [user_id]) do |result|

ruby/spec/factories.rb

@@ -91,11 +91,6 @@ FactoryGirl.define do
     as_musician true
     addr 0
     locidispid 0
-    latitude 0.0
-    longitude 0.0
-    countrycode 'US'
-    region 'TX'
-    city 'Austin'
     client_type 'client'
   end
 

ruby/spec/jam_ruby/connection_manager_spec.rb

@@ -78,11 +78,6 @@ describe ConnectionManager do
     cc.ip_address.should eql("1.1.1.1")
     cc.addr.should == 0x01010101
     cc.locidispid.should == 17192000002
-    cc.latitude.should == 30.2076
-    cc.longitude.should == -97.8587
-    cc.city.should eql('Austin')
-    cc.region.should eql('TX')
-    cc.countrycode.should eql('US')
 
     count = @connman.delete_connection(client_id)
     count.should == 0
@@ -113,11 +108,6 @@ describe ConnectionManager do
     cc.ip_address.should eql("1.1.1.1")
     cc.addr.should == 0x01010101
     cc.locidispid.should == 17192000002
-    cc.latitude.should == 30.2076
-    cc.longitude.should == -97.8587
-    cc.city.should eql('Austin')
-    cc.region.should eql('TX')
-    cc.countrycode.should eql('US')
 
     @connman.reconnect(cc, nil, "33.1.2.3")
 
@@ -126,11 +116,6 @@ describe ConnectionManager do
     cc.ip_address.should eql("33.1.2.3")
     cc.addr.should == 0x21010203
     cc.locidispid.should == 30350000003
-    cc.latitude.should == 29.7633
-    cc.longitude.should == -95.3633
-    cc.city.should eql('Houston')
-    cc.region.should eql('TX')
-    cc.countrycode.should eql('US')
 
     count = @connman.delete_connection(client_id)
     count.should == 0

ruby/spec/jam_ruby/models/track_spec.rb

@@ -4,7 +4,7 @@ describe Track do
 
   let (:user) {FactoryGirl.create(:user) }
   let (:music_session) { FactoryGirl.create(:music_session, :creator => user)}
-  let (:connection) { FactoryGirl.create(:connection, :music_session => music_session) }
+  let (:connection) { FactoryGirl.create(:connection, :user => user, :music_session => music_session) }
   let (:track) { FactoryGirl.create(:track, :connection => connection)}
   let (:track2) { FactoryGirl.create(:track, :connection => connection)}
   let (:msuh) {FactoryGirl.create(:music_session_user_history, :history => music_session.music_session_history, :user => user, :client_id => connection.client_id) }

web/spec/factories.rb

@@ -89,11 +89,6 @@ FactoryGirl.define do
     as_musician true
     addr 0
     locidispid 0
-    latitude 0.0
-    longitude 0.0
-    countrycode 'US'
-    region 'TX'
-    city 'Austin'
     client_type 'client'
   end
 

websocket-gateway/spec/factories.rb

@@ -35,11 +35,6 @@ FactoryGirl.define do
   factory :connection, :class => JamRuby::Connection do
     addr 0
     locidispid 0
-    latitude 0.0
-    longitude 0.0
-    countrycode 'US'
-    region 'TX'
-    city 'Austin'
     ip_address '1.1.1.1'
     as_musician true
     client_type 'client'