From 4ef19e43564578e291eec83f1db6aef4f3a54164 Mon Sep 17 00:00:00 2001 From: Anthony Davis Date: Sat, 22 Feb 2014 21:12:12 -0600 Subject: [PATCH] VRFS-1218 DRYing it slightly, move toward VRFS-1214 --- web/spec/features/recordings_spec.rb | 16 ++-------------- web/spec/support/utilities.rb | 8 ++++++++ 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/web/spec/features/recordings_spec.rb b/web/spec/features/recordings_spec.rb index 573199fbb..682870117 100644 --- a/web/spec/features/recordings_spec.rb +++ b/web/spec/features/recordings_spec.rb @@ -36,13 +36,7 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature # confirms that a formal leave (by hitting the 'Leave' button) will result in a good recording it "creator starts and then leaves" do start_recording_with(creator, [joiner1]) - - in_client(creator) do - find('#session-leave').trigger(:click) - find('#btn-accept').trigger(:click) - expect(page).to have_selector('h2', text: 'feed') - end - + formal_leave_by creator check_recording_finished_for [creator, joiner1] end @@ -73,13 +67,7 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature it "creator starts with session leave to stop, with 3 total participants" do start_recording_with(creator, [joiner1, joiner2]) - - in_client(creator) do - find('#session-leave').trigger(:click) - find('#btn-accept').trigger(:click) - expect(page).to have_selector('h2', text: 'feed') - end - + formal_leave_by creator check_recording_finished_for [creator, joiner1, joiner2] end diff --git a/web/spec/support/utilities.rb b/web/spec/support/utilities.rb index 7d44a27ea..081a15e38 100644 --- a/web/spec/support/utilities.rb +++ b/web/spec/support/utilities.rb @@ -208,6 +208,14 @@ def create_join_session(creator, joiners=[], genre=nil) end end +def formal_leave_by user + in_client(user) do + find('#session-leave').trigger(:click) + find('#btn-accept').trigger(:click) + expect(page).to have_selector('h2', text: 'feed') + end +end + def start_recording_with(creator, joiners=[], genre=nil) create_join_session(creator, joiners, genre) in_client(creator) do