diff --git a/web/app/assets/javascripts/react-components/PopupSessionRecording.js.jsx.coffee b/web/app/assets/javascripts/react-components/PopupSessionRecording.js.jsx.coffee
index acb44dd9e..e6c24e168 100644
--- a/web/app/assets/javascripts/react-components/PopupSessionRecording.js.jsx.coffee
+++ b/web/app/assets/javascripts/react-components/PopupSessionRecording.js.jsx.coffee
@@ -36,37 +36,49 @@ mixins.push(Reflux.listenTo(@AppStore,"onAppInit"))
handleSettingSubmit: (settings) ->
volume = volume: @state.inputGroupMixers.mixer[0].volume_left
- recordSettings = $.extend({}, settings, volume)
- console.log('_DEBUG_ recordSettings', JSON.stringify(recordSettings))
+ settings = $.extend({}, settings, volume)
try
- localStorage.setItem("recordSettings", JSON.stringify(recordSettings))
+ localStorage.setItem("recordSettings", JSON.stringify(settings))
catch e
logger.info("error while saving recordSettings to localStorage")
logger.log(e.stack)
- recordType = recordSettings.recordingInputType
- #TODO: check OBS has been installed
- obsReady = false
+ params = {
+ recordingType: settings.recordingType,
+ name: settings.recordingName,
+ audioFormat: settings.audioFormat,
+ includeChat: settings.includeChat,
+ volume: settings.volume,
+ }
- if recordType == context.JK.RECORD_TYPE_BOTH && !obsReady
- context.JK.Banner.showAlert("To make a video recording in JamKazam, you must first install and configure OBS software. Click the link below for a help article that explains how to do this. View Help Article")
- return
- @startStopRecording(recordSettings)
+ if params.recordingType == context.JK.RECORD_TYPE_BOTH
+ params['videoFormat'] = settings.videoFormat
+ params['audioDelay'] = settings.audioDelay
+
+ #TODO: check OBS has been installed
+ obsReady = true
+
+ unless obsReady
+ context.JK.Banner.showAlert("To make a video recording in JamKazam, you must first install and configure OBS software. Click the link below for a help article that explains how to do this. View Help Article")
+ return
+
+ unless context.JK.videoIsOngoing
+ context.JK.Banner.showAlert("To make a video recording in JamKazam you must have an ongoing video. You can start a video by clicking the Video button on session tool bar.")
+ return
+
+ console.log('_DEBUG_ starting recording', JSON.stringify(params))
+ @startStopRecording(params)
closeDialog: () ->
@app.layout.cancelDialog('session-recording')
- startStopRecording: (settings) ->
+ startStopRecording: (params) ->
if @state.isRecording
RecordingActions.stopRecording()
else
- recordChat = settings.includeChat
- recordVideo = settings.recordingInputType == 'audio-video'
- if recordVideo
- return unless context.JK.videoIsOngoing
-
- logger.debug("@inputType, @udiotye", recordChat, recordVideo)
- RecordingActions.startRecording(recordVideo, recordChat)
+ #logger.debug("@inputType, @udiotye", recordChat, recordVideo)
+ #RecordingActions.startRecording(recordVideo, recordChat)
+ RecordingActions.startRecording(params)
render: () ->
if Object.keys(@state.inputGroupMixers).length > 0 then `