VRFS-1021 - tests were implicitly order-dependent, also fixing to use new ActiveMusicSession model
This commit is contained in:
parent
50d1696ad3
commit
3736b93968
|
|
@ -105,6 +105,8 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature
|
|||
|
||||
RecordedTrack.delete_all
|
||||
ClaimedRecording.delete_all
|
||||
MusicSession.delete_all
|
||||
ActiveMusicSession.delete_all
|
||||
|
||||
start_recording_with(creator, [joiner1], some_genre)
|
||||
|
||||
|
|
@ -117,7 +119,7 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature
|
|||
end
|
||||
|
||||
it "discard the recording" do
|
||||
pending "fails intermittently on the build server"
|
||||
# pending "fails intermittently on the build server"
|
||||
in_client(creator) do
|
||||
find('#recording-finished-dialog h1')
|
||||
find('#discard-session-recording').trigger(:click)
|
||||
|
|
@ -142,7 +144,7 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature
|
|||
end
|
||||
|
||||
it "claim recording with unique names/descriptions" do
|
||||
pending "intermittent failure on build server, hard to repro on local system"
|
||||
# pending "intermittent failure on build server, hard to repro on local system"
|
||||
@users.each do |user|
|
||||
name = "#{user.name}'s recording"
|
||||
desc = "#{user.name}'s description"
|
||||
|
|
@ -155,7 +157,7 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature
|
|||
expect(claimed_recording.name).to eq(name)
|
||||
expect(claimed_recording.description).to eq(desc)
|
||||
expect(claimed_recording.is_public).to be_true
|
||||
expect(claimed_recording.genre).to eq(music_session.genres[0])
|
||||
expect(claimed_recording.genre).to eq(music_session.genre)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
@ -168,13 +170,12 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature
|
|||
fill_in "claim-recording-description", with: "my description"
|
||||
find('#keep-session-recording').trigger(:click)
|
||||
should have_content("can't be blank")
|
||||
save_screenshot("tmp/name#{user.name}.png")
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
it "a 'Description' is optional" do
|
||||
pending "intermittent failure on build server, hard to repro on local system"
|
||||
# pending "intermittent failure on build server, hard to repro on local system"
|
||||
@users.each do |user|
|
||||
in_client(user) do
|
||||
claim_recording("my recording", '')
|
||||
|
|
@ -184,7 +185,7 @@ describe "Session Recordings", :js => true, :type => :feature, :capybara_feature
|
|||
expect(claimed_recording.name).to eq("my recording")
|
||||
expect(claimed_recording.description).to eq('')
|
||||
expect(claimed_recording.is_public).to be_true
|
||||
expect(claimed_recording.genre).to eq(music_session.genres[0])
|
||||
expect(claimed_recording.genre).to eq(music_session.genre)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
|
|||
Loading…
Reference in New Issue