seth
/
jam-cloud
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

* VRFS-1253 - account for unknowns

This commit is contained in:
Seth Call 2014-03-09 19:35:42 +00:00
parent 5a8c3886fd
commit 23e5906e55
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ruby/lib/jam_ruby/models/music_session.rb
View File

@ -206,7 +206,7 @@ module JamRuby
locidispid = connection.locidispid
query = MusicSession
.select("music_sessions.*, max(coalesce(current_scores.score, 99)) as max_score")
.select("music_sessions.*, max(coalesce(current_scores.score, 1000)) as max_score") # 1000 is higher than the allowed max of 999
.joins(
%Q{
INNER JOIN

10
web/app/assets/javascripts/sessionList.js
View File

@ -11,7 +11,8 @@
GOOD : {description: "GOOD", style: "latency-green", min: 0.0, max: 20.0},
MEDIUM : {description: "MEDIUM", style: "latency-yellow", min: 20.0, max: 40.0},
POOR : {description: "POOR", style: "latency-red", min: 40.0, max: 10000000000.0},
UNREACHABLE: {description: "UNREACHABLE", style: "latency-grey", min: -1, max: -1}
UNREACHABLE: {description: "UNREACHABLE", style: "latency-grey", min: -1, max: -1},
UNKNOWN: {description: "UNKNOWN", style: "latency-grey", min: -2, max: -2}
};
var AUDIENCE = {
@ -49,6 +50,11 @@
latencyStyle = LATENCY.UNREACHABLE.style;
showJoinLink = false;
}
else if(latencyInfo.averageLatency === 1000) {
// 1000 is a magical number returned by new scoring API to indicate one or more people in the session have an unknown score
latencyDescription = LATENCY.UNKNOWN.description;
latencyStyle = LATENCY.UNKNOWN.style;
}
else {
if (totalLatency <= LATENCY.GOOD.max) {
latencyDescription = LATENCY.GOOD.description;
@ -61,7 +67,7 @@
else {
latencyDescription = LATENCY.POOR.description;
latencyStyle = LATENCY.POOR.style;
//showJoinLink = false;
//showJoinLink = false; # let people join any scored session is the current thinking
}
}